Avoid JSON errors with interval > 27263 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long story short: JSON encoding a serialized PHP object can fail due to invalid UTF-8 characters. Avoid this by serializing the whole storage entry instead. This basically leads to double-serialization of the limiter state but this is actually no problem.
|
@mbrodala Thanks for the bug report and the pull request. I'll have a look in the next days. |
|
Thanks for the investigation. I opted for a json_decode and on error unserialize the value, so no upgrade wizard is necessary (which would also not be expected on a bugfix release). The fallback will then be removed with version 2.0.0. |
|
Thanks for the adjustment and merge in 435d9c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short: JSON encoding a serialized PHP object can fail due to invalid UTF-8 characters.
Avoid this by serializing the whole storage entry instead. This basically leads to double-serialization of the limiter state but this is actually no problem.
Technically we'd also need an upgrade wizard or similar to migrate existing JSON-based entries but this is beyond my time.
Fixes #5