style: Conform to Ansible > 2.10 (#4)

style(attrauth): fix lint issues in playbook
style(apache): fix ansible-lint issues in defaults and handlers
style(apache): fix lint in OS-dependent configuration tasks
style(apache): fix linting issues in ssl config tasks
style(apache): apply ansible-lint's opinionated fix to role
style(apache): align name of handler to respect ansible-lint rules
style(apache): apply lint fixes to main tasks
style(comange-registry): apply linting rules to defaults
style(comange-registry): apply linting rules to configure tasks
style(comanage): declare no changes in ad-hoc commands
  This should be updated when we know how to identify a change in order to ensure idempotency
style(comanage): split long install command over several lines
style(comanage): apply linting fixes to install tasks
style(comanage): explicitly ignore idempotency in cache clear task
style(comanage): explicitly ignore idempotency in static files tasks
style(php): fix linting errors in role defaults
style(php): fix linting errors in role defaults
style(php): fix linting errors in role taks and vars
style(shibboleth-sp): fix linting errors in role defaults
style(shibboleth-sp): fix linting errors in role main tasks
style(shibboleth-sp): fix all linting errors in role
WIP rciam#270
WIP rciam#267
style(common): apply linting rules to role defaults
style(common): apply linting rules to role defaults
style(common): fix linting errors in main role tasks
style(common): apply linting fixes to role tasks and vars
style(ssp): make role defaults pass ansible lint
chore(deps): freeze current requirements for dependabot
style(ssp): apply style rules to ssp handlers
style(ssp): reduce linting warnings in role composer tasks
style(ssp): apply linting rules to configure-common tasks
style(ssp): ensure configure-saml and shib tasks pass lint
style(ssp): ensure authservers playbook passes Ansible lint
WIP rciam#270
style(authzkeys): conform to Ansible Lint style
style(cache): conform to ansible style guide
style(cert2saml): conform to ansible style for ssp module role
style(comanage): conform comanage playbook and roles to Ansible style guide
style(d4science): conform playbook to Ansible lint
style(postgres): conform db playbook and postgres role to ansible lint
style(egi-igtf): conform EGI IGTF role and playbook to Ansible Lint
refactor(egi-igtf): move task to handler
style(deep2saml): conform playbook to Ansible Lint
style(federation-registry): conform to ansible lint
Some task modules have been changed from postgresql_query to postgresql_script
style(fedreg): conform to ansible lint
style(firewall): conform to ansible lint
style(google2saml): conform to ansible lint
chore: ignore editor cruft
style(keycloak): conform to Ansible Lint
style(keycloak): conform to Ansible Lint
style(metrics): conform metrics servers to Ansible Lint
style(monservers): conform monservers to Ansible Lint
style(oauth2saml): conform to Ansible Lint
style(ldap): conform to Ansible Lint
style(orcid): conform to Ansible Lint
style(rciam-keycloak,nginx,rsyslog,webproxy): conform to Ansible Lint
style(oidc): conform to Ansible Lint
style(registry-ui): conform to Ansible Lit
chore: add detect-secrets pre-commit hook
style(saml,oidc): conform to Ansible Lint
style(secrets): conform to Ansible Lint
style(site): conform to Ansible Lint
style(ssp): conform to Ansible Lint
fix(apache): fix module name
style(utils): conform to Ansible Lint
style: conform to Ansible Lint

---------

Signed-off-by: Bruce Becker <brucellino@protonmail.ch>
Signed-off-by: Bruce Becker <bruce.becker@egi.eu>

.ansible-lint

@@ -0,0 +1,9 @@
+exclude_paths:
+  - .pre-commit-config.yaml
+  - icingaagents.yml
+  - roles/common/handlers/main.yml
+  - authzkeys.yml
+  - inventories
+offline: false
+skip_list:
+  - role-name

.gitignore

@@ -5,7 +5,8 @@
 .LSOverride
 
 # Icon must end with two \r
-Icon
+Icon
+
 
 # Thumbnails
 ._*
@@ -25,3 +26,6 @@ Network Trash Folder
 Temporary Items
 .apdisk
 # END OSX.gitignore
+
+# ignore editor cruft
+.vscode

.pre-commit-config.yaml

@@ -8,6 +8,15 @@ repos:
     - id: end-of-file-fixer
     - id: check-yaml
     - id: check-added-large-files
+    - id: requirements-txt-fixer
+
+- repo: https://github.com/Yelp/detect-secrets
+  rev: v1.4.0
+  hooks:
+    - id: detect-secrets
+      args:
+        - --baseline
+        - .secrets.baseline
 
 - repo: https://github.com/ansible-community/ansible-lint
   rev: v24.2.1
@@ -18,11 +27,15 @@ repos:
       exclude: .github
       additional_dependencies:
         - ansible-core>=2.16.0
-      args: [
-        "--exclude", ".pre-commit-config.yaml",
-        "--exclude", "roles/" # Exclude roles for now.
-      ]
-
+      args:
+        - --exclude
+        - .pre-commit-config.yaml
+        - icingaagents.yml
+        # For some reason noqa is not being picked up on these files
+        - roles/common/handlers/main.yml
+        - authzkeys.yml
+        # ssp-modules is a bad name for a role
+        - roles/ssp-modules
 
 - repo: https://github.com/python-jsonschema/check-jsonschema
   rev: 0.28.0