Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gr740 #91

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Gr740 #91

wants to merge 4 commits into from

Conversation

emercadal
Copy link
Contributor

@emercadal emercadal commented Oct 5, 2023

Adds extensions to support static instrumentation on GR740 embedded board.

Munesanz and others added 3 commits November 18, 2019 17:44
Change-Id: I8ff77d699d6393ccb63fa7583b394b594cb4b02f
Change-Id: I1bd5b07d41088046f8cc3860199fb3ee6dfd9430
Change-Id: I3422cc1de47c1b88705f5b2f18d069a2c7076126
src/common/utils.c Outdated Show resolved Hide resolved
config/openmp.m4 Outdated Show resolved Hide resolved
configure.ac Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for missing LINK_WRAP / GET_REAL_FUNCTION / function weak definitions. Newer functions probably not added.

@@ -42,33 +42,38 @@
} \
}

#if defined(PIC)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was if defined(PIC) removed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because we wanted the omp functions to be defined for RTEMS too, which is not PIC. Instead of deleting it I suggest to change it to "#if defined(PIC) || defined (OS_RTEMS)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do functions in l. 51 to 54 exist in the runtime with these names? (__real_XXX)

Copy link

@Munesanz Munesanz Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are functions from the libgomp runtime. The "--wrap" GCC linker flag adds the "_real" prefix to the real symbols in the libgomp library.

Copy link
Contributor Author

@emercadal emercadal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments.

Change-Id: Icca5dc77c8bd254a7067efcd32d63a203ee0f488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants