ci: pin the release checkout to the commit CI validated - #93
Merged
Conversation
btravstack/tools#6 added a `ref` input to the shared release workflow, and `workflows-v1` now points at it. Passing `github.event.workflow_run.head_sha` checks out the exact commit the green run measured; without it a `workflow_run` checkout takes the default branch's CURRENT tip, which a push landing after CI went green can have moved — cutting a permanent npm tarball from a commit no CI run validated. The window is small and the newer commit gets its own CI run, but a tarball cannot be unpublished after 72 hours. btravstack/btravstack's `deploy-docs.yml` has guarded the identical hazard all along for a redeployable site. Nothing else changes here: the same tag move already brought `changesets/action@v2` to this repository, which is what stops a `.changeset/CLAUDE.md` from failing every release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies btravstack/tools#6's
refinput, now thatworkflows-v1points atbtravstack/tools@01ed3e01.The exact commit the green CI run measured. Without it a
workflow_runcheckout takes the default branch's current tip, which a push landing after CI went green can have moved — so a permanent npm tarball gets cut from a commit no CI run validated.The window is small and the newer commit gets its own CI run, but a tarball cannot be unpublished after 72 hours, which is why this is worth closing rather than living with.
btravstack/btravstack'sdeploy-docs.ymlhas guarded the identical hazard all along for a redeployable site.Nothing else to do here
The same tag move already brought
changesets/action@v2to this repository for free. That matters even though nothing here is broken today: v1 bundles@changesets/read@^0.6.7, which parses every.changeset/*.mdas a changeset, so adding a.changeset/CLAUDE.md— an ordinary thing to do — would have failed every release withcould not parse changeset - missing or invalid frontmatter. It is what happened tobtravstack/btravstack.@changesets/read@1.0.0ignoresREADME.md,AGENTS.md,CLAUDE.mdandGEMINI.md.It also moved both workflows off
pnpm/action-setup@v4andactions/setup-node@v4, which were forced onto Node 24 with a deprecation warning on every run.