Upgrade azidentity to v1.5.2 #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostynb
approved these changes
May 11, 2024
There was a problem hiding this comment.
Thanks for the submission- this looks good.
IIRC the go azure sdk made a bunch of breaking changes since the azblob feature was added here, but I am unable to easily update it since I don't have an azure account to test against. If you would like to try upgrading that, PRs would be welcome.
|
Sounds good 👍 When do you think the next release will be cut? |
|
I'm trying to help get #740 landed this week, once that's done it might be a good time for a new release. And if it looks like that PR will take too long, then I can probably make a release at the end of this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on setting up
bazel-remotein a Kubernetes cluster, as a proxy on top of an Azure Storage Account. To avoid injecting static credentials into the deployment, I would like to configure Entra Workload ID (tl;dr: the resulting pod is mutated and temporary credentials are injected as environment variables).Unfortunately, the minimum required version of
azidentitythat supports Workload ID via thedefaultauthentication method isv1.3.0.This PR updates it to it latest version (
v1.5.2) fromv1.1.0.