Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSPP] Implementation of TorchDynamo compiler #208

Merged
merged 5 commits into from
Oct 24, 2023
Merged

[OSPP] Implementation of TorchDynamo compiler #208

merged 5 commits into from
Oct 24, 2023

Conversation

xTayEx
Copy link
Contributor

@xTayEx xTayEx commented Sep 21, 2023

No description provided.

@zhanghb97 zhanghb97 added this to the llama-inference milestone Oct 9, 2023
@xTayEx xTayEx force-pushed the develop branch 4 times, most recently from ddca1f2 to 94e9bdd Compare October 14, 2023 07:30
@xTayEx xTayEx changed the title [WIP][example][MLIRPython] Add bert operators' implementation [OSPP] Implementation of TorchDynamo compiler Oct 14, 2023
@xTayEx xTayEx force-pushed the develop branch 2 times, most recently from f5954b3 to a58079f Compare October 15, 2023 12:18
@notion-workspace
Copy link

[Review] Torch Dynamo Compiler

zhanghb97
zhanghb97 reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@zhanghb97 zhanghb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xTayEx Nice patch!
We also need to add the following items:

  • Docstrings for conversion functions (see the example for addmm)
  • Tests for these conversion functions (see here as an example)
  • Add a README for BuddyPython and describe the design points and import strategy.

frontend/Python/ops/tosa.py Show resolved Hide resolved
@zhanghb97 zhanghb97 mentioned this pull request Oct 23, 2023
Merged
zhanghb97
zhanghb97 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@zhanghb97 zhanghb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please fix these formatting issues.
We are almost there!

tests/Python/test_embedding.py Outdated Show resolved Hide resolved
tests/Python/test_var_mean.py Outdated Show resolved Hide resolved
tests/Python/test_view.py Outdated Show resolved Hide resolved
@xTayEx
Copy link
Contributor Author

xTayEx commented Oct 24, 2023 •
edited
Loading

@zhanghb97 Thank you for your review! I have updated just now and the format issues should be fixed

@zhanghb97 zhanghb97 merged commit d85c3a5 into buddy-compiler:main Oct 24, 2023
1 check passed
@zhanghb97
Copy link
Member

Congrats 🎉🎉🎉
Thank you for your contribution. Hope you enjoyed the OSPP project!

ShiHaoGao pushed a commit to ShiHaoGao/buddy-mlir that referenced this pull request Oct 18, 2024
@xTayEx
[OSPP] Implementation of TorchDynamo compiler (buddy-compiler#208)
68b485d 
* [frontend] Add tosa operators for python frontend

* [frontend] Support keyword arguments in importer

* [frontend] Add docstring for tosa operators

* [frontend] Add README.md for `BuddyPython`

* [frontend] Add tests for tosa operator conversion functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanghb97 zhanghb97 zhanghb97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
llama-inference
Development

Successfully merging this pull request may close these issues.
2 participants
@xTayEx @zhanghb97