Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow token to be empty if graphql-token is provided #3051

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jordandcarter
Copy link
Contributor

Description

Fixes tool sign when using --graphql-token.

Context

Running tool sign --graphql-endpoint http://graphql.buildkite.localhost/v1 --graphql-token this_is_not_the_actual_token kept returning an error fatal: Error signing pipeline: couldn't retrieve pipeline: Post "http://graphql.buildkite.localhost/v1": Invalid token, empty string supplied

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@jordandcarter jordandcarter changed the title Allow token to be empty if bearer is provided Allow token to be empty if graphql-token is provided Oct 24, 2024
@jordandcarter jordandcarter requested a review from a team October 24, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant