Book ISBN is not nullable anymore

Type went from 'string | null' to 'string', this is a breaking change.
bump-sh · Oct 16, 2023 · 14fb146 · 14fb146
1 parent 5b9f449
commit 14fb146
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/api/src/Entity/Book.php b/api/src/Entity/Book.php
@@ -27,9 +27,9 @@ class Book
     #[ORM\Id, ORM\Column, ORM\GeneratedValue]
      private ?int $id = null;
 
-     /** The ISBN of this book (or null if doesn't have one). */
-    #[ORM\Column(nullable: true)]
-     public ?string $isbn = null;
+     /** The ISBN of this book. */
+    #[ORM\Column]
+     public ?string $isbn = '';
 
      /** The title of this book. */
     #[ORM\Column]

diff --git a/docs/openapi.json b/docs/openapi.json
@@ -794,8 +794,7 @@
                         "type": "integer"
                     },
                     "isbn": {
-                        "type": "string",
-                        "nullable": true
+                        "type": "string"
                     },
                     "title": {
                         "type": "string"
@@ -864,8 +863,7 @@
                         "type": "integer"
                     },
                     "isbn": {
-                        "type": "string",
-                        "nullable": true
+                        "type": "string"
                     },
                     "title": {
                         "type": "string"