Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview: fix (again) the “live preview” feature #514

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented Oct 5, 2023

This commit makes sure to only create one preview (the previous
tentative fix on live previews would create 1 preview, then a 2nd
preview, and then update that 2nd preview).

Follow-up to #456 (cf #182)

This commit makes sure to only create one preview (the previous
tentative fix on live previews would create 1 preview, then a 2nd
preview, and then update that 2nd preview).

Follow-up to bump-sh#456 (cf bump-sh#182)
@paulRbr paulRbr added the bug Something isn't working label Oct 16, 2023
Copy link
Contributor

@fbraure fbraure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK to me

@paulRbr paulRbr merged commit 53e4d2c into bump-sh:main Oct 19, 2023
9 checks passed
@paulRbr paulRbr deleted the fix-live-preview-again branch November 27, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants