Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lengths #533

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

tarmo888
Copy link
Member

@tarmo888 tarmo888 commented Jul 26, 2020

Text should be as long as modern tweets (280 chars) and longer than any data (profile, poll, attestation) limits, otherwise someone wanting to timestamp some text would just post it as some other type, which has higher limit.

  • changed text limit from 140 to 280 and made textarea as high as the definition text area.
  • some inputs had ng-maxlength and maxlength, some only ng-maxlength. made all have both.

These changes Tony copy-pasted from my Pull Request:

  • added character limit to poll question, previously only poll options were limited.
  • fixed profile/attestation key and value lengths to match lengths in constants.js
  • fixed datafeed value length to be limited to 64 while keeping the raw data value to 256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant