HTML Composer 1 - IR changes #162
Conversation
|
Those added shortcuts in the IR look good! I'm guessing it's failing the Python 3.5 test because of OrderedDict(). |
|
yes I will fast-forward this once we merge #161, that should fix it |
|
I'm going to wait to merge this until we know our plan with extending classes. |
|
Now that extending classes with extensions is an option, would you be able to make the html composer into an extension? |
jacobdbrown4
changed the base branch from
ganesh_contributions
to
next_release
|
The ganesh_contributions branch was deleted, so the pull request automatically closed. I recreated the branch, reopened the pull request, changed the target branch to next_release, then deleted ganesh_contributions again. For some reason now in the comments above it says the wirthlin deleted next_release but that is not right. He deleted ganesh_contributions. I just thought I would clarify that in a comment here. |
I used many shortcuts while creating HTML composer, so I am trying to split them into multiple pull requests.
This pull request contains additions in ir classes,
I tried to add tests also but I guess that will keep evolving.
We can discuss functionality in more detail and the required tests.