Fix wrong v value on ethereum signature
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josher8a Thank you and your great team. I have already merged the PR and published a new version on pub.dev https://pub.dev/packages/ecdsa/versions/0.1.1 |
|
Thank you, sir 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue #6 with the calculation of the
vvalue in the ethereum signature. The current implementation is returningv = 1instead ofv = 0, which is causing the end of the signature to be different. The fix involves updating the calculation ofvto use a bitwise XOR operation with1whensis greater than half of the curve's order.The pull request also includes a test case to ensure that the fix is working correctly.