Skip to content

Commit

Permalink
use Date for last release instead of string
Browse files Browse the repository at this point in the history
  • Loading branch information
nafiz1001 committed Oct 8, 2024
1 parent 72887e0 commit 26c92b1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 4 additions & 4 deletions triton-client/src/components/DatasetColumns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface DatasetColumnSource {
id: TritonDataset["id"]
lane: TritonDataset["lane"]
external_project_id: TritonDataset["external_project_id"]
latest_release_update: TritonDataset["latest_release_update"]
latest_release_update: Date
isFetchingRequest: boolean
activeRequest: RequestState | undefined
totalSize: number
Expand Down Expand Up @@ -105,11 +105,11 @@ export function useDatasetColumns(
width: "10%",
defaultSortOrder: "descend",
sorter: (a, b) =>
new Date(a.latest_release_update).getTime() -
new Date(b.latest_release_update).getTime(),
a.latest_release_update.getTime() -
b.latest_release_update.getTime(),
render: (date) => {
if (date) {
return new Date(date).toUTCString()
return date.toUTCString()
} else {
return "-"
}
Expand Down
4 changes: 3 additions & 1 deletion triton-client/src/components/DatasetList/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ export default function DatasetList({ externalProjectID }: DatasetListProps) {
id: dataset.id,
lane: dataset.lane,
external_project_id: dataset.external_project_id,
latest_release_update: dataset.latest_release_update,
latest_release_update: new Date(
dataset.latest_release_update,
),
isFetchingRequest: true,
activeRequest: undefined,
totalSize: 0, // size of 0 indicates that the size is not yet fetched
Expand Down

0 comments on commit 26c92b1

Please sign in to comment.