This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
Update VFS-local to work on Windows #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's going on with this pull request? Is no one maintaining this repo anymore? |
|
We'll update this repo within a few weeks during our work to open source cloud9. |
|
Ok, thank you for the fast answer. i really like this vfs project and was not sure if it's still maintained. i'm really keen to use it, so thanks in advance for the good work :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to introduce some changes to let VFS work on Windows.
There are four tests not passing:
vfs.rmfilevf.rmdirvfs.symlinkvfs.execFileMost of these are permission settings--I am getting
EPERMerrors for some reason. This is compatible with errors I saw in #7.This should also fix #1. It's not that it doesn't work on Windows, it's that the testing infrastructure makes too many incorrect assumptions about dir paths. Everything else is golden since it relies on
fs.