Add stable status page theme hooks - #451
Conversation
Apply every declared render hook and add missing boundaries around status summaries, incident timelines, and unsubscribe content. Expose stable page, component, slot, and record selectors so themes do not depend on implementation classes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0996749d39
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private ?string $title = null, | ||
| private ?string $description = null | ||
| private ?string $description = null, | ||
| private string $page = 'status', |
There was a problem hiding this comment.
The default marks every layout consumer as data-page="status", but resources/views/setup/index.blade.php:1 also uses <x-cachet::cachet> without a page argument. Consequently, the public /setup route is misidentified as the status page and custom themes targeting the new stable status selector can unintentionally restyle the setup form; pass page="setup" there or avoid a misleading status default.
Useful? React with 馃憤聽/ 馃憥.
| @@ -1,7 +1,11 @@ | |||
| {{ \Cachet\Facades\CachetView::renderHook(\Cachet\View\RenderHook::STATUS_PAGE_METRICS_BEFORE) }} | |||
There was a problem hiding this comment.
When app.display_graphs is false, resources/views/status-page/index.blade.php skips <x-cachet::metrics> entirely, so neither newly exposed metrics hook in this view is evaluated. Extensions therefore cannot use these hook positions on installations that disable the built-in charts; render the hook boundaries outside the $display_graphs conditional or condition only the built-in metric content.
Useful? React with 馃憤聽/ 馃憥.
1 participant
Summary
Documentation
Testing