Gets the latest version of Cake from GitHub #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecampidoglio
force-pushed
the
bug/gh-55-get-latest-version-from-github
branch
3 times, most recently
from
6423e8b
to
344b01b
Compare
ecampidoglio
force-pushed
the
bug/gh-55-get-latest-version-from-github
branch
from
344b01b
to
6988b16
Compare
Earlier, not providing an argument for the `cake-version` input parameter resulted in the Cake.Tool being installed without the `--version` parameter. This is fine in most cases, since in practice it translates into installing the latest version. The case when it stops being fine is when an earlier version of the Cake.Tool is already installed in the tools directory and you're running the action without a version number. In that case, you would expect the action to uninstall the existing version of the Cake.Tool and install the latest one, but what used to happen instead is that the action wouldn't even check what version was installed, since it had no version number to compare with, and it would just use whatever version of the tool was already installed. This commit addresses this corner case by explicitly fetching the latest version of the Cake.Tool from GitHub when no version number is specified by the user. This way, the action is able to compare that version number with whatever may already be installed and act appropriately.
ecampidoglio
force-pushed
the
bug/gh-55-get-latest-version-from-github
branch
from
6988b16
to
f125c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #55 by fetching the version of the latest
Cake.Toolrelease through the GitHub REST API.