New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle message decoding more safely #20

Open

tobiasmcnulty wants to merge 4 commits into main from safe-decoding

Member

tobiasmcnulty commented Jun 22, 2024 •

edited

Loading

This PR makes a few changes to how messages are decoded:

The admin list view should not generate a 500 error in case of a bad data_coding or invalid unicode characters
Add support for ISO-8859-1 (both as a fallback when data_coding = 0 and for the official data_coding = 3)
In case a MO message fails to decode, it is moved to a new ERROR status

Screenshot 2024-06-22 at 2 41 50 PM

To do:

Figure out why exceptions in receive() result in none of the messages being set to DONE status, contrary to our unit test test_error_in_middle_of_patch

tobiasmcnulty added 4 commits

June 22, 2024 14:43


          Handle decoding more safely

0beb81d


          Reduce number of messages processed in bulk when workers start

9581d7f


          Reduce complexity of bulk handling in handle_mo_messages()

6a62602


          Only receive one pg_notify per loop execution

e8f6b43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet