Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNP scoring optimizations #22

Merged
merged 8 commits into from
Apr 9, 2024
Merged

SNP scoring optimizations #22

merged 8 commits into from
Apr 9, 2024

Conversation

davek44
Copy link
Collaborator

@davek44 davek44 commented Apr 4, 2024

Description of your changes

Several updates to optimize SNP scoring.

All validated on eQTL prediction task.

lruizcalico
lruizcalico approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@lruizcalico lruizcalico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_ism was failing so I added None - strand_transform to hound_ism_bed and hound_ism_snp.

@davek44 davek44 merged commit ea5231b into main Apr 9, 2024
3 checks passed
@davek44 davek44 deleted the snp-strand branch April 9, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyakors anyakors anyakors approved these changes

@lruizcalico lruizcalico lruizcalico approved these changes

@DivyanshiSrivastava DivyanshiSrivastava Awaiting requested review from DivyanshiSrivastava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davek44 @anyakors @lruizcalico