Skip to content

fix(test): drain session-event-log writes before rmSync cleanup in save-script transport tests #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Aug 24, 2026
Merged

fix(test): drain session-event-log writes before rmSync cleanup in save-script transport tests #1999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/daemon/__tests__/request-save-script-transports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {
skipWhenLoopbackUnavailable,
} from '../../__tests__/test-utils/loopback.ts';
import { mkdtempForTestSync } from '../../__tests__/test-utils/tmp-dir.ts';
import { flushSessionEventLogWrites } from '../session-event-log.ts';

const TOKEN = 'save-script-transport-token';
const SESSION = 'save-script-transport';
Expand All @@ -53,7 +54,10 @@ type Harness = {

const roots: string[] = [];

afterEach(() => {
afterEach(async () => {
// #1998: request handling queues fire-and-forget session-event-log appends;
// drain them before rmSync or a late append re-creates the dir → ENOTEMPTY.
await flushSessionEventLogWrites();
for (const root of roots.splice(0)) fs.rmSync(root, { recursive: true, force: true });
});

Expand Down
Loading