Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Auto-completion for kubernetes mid-string #997

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented Oct 13, 2023

Continue #990 and #995

Now instead of auto-completing the whole value of the parameter, the string can contain several placeholders and other pieces of string that won't get removed by the auto-completion.

Screencast.from.2023-10-13.13-49-40.webm

@Delawen
Copy link
Contributor Author

Delawen commented Oct 13, 2023

Not sure if this deserves a changelog or it can be included as part of the kubernetes context auto-completion lines in the changelog.

@Delawen Delawen changed the title feature: Auto-completion for kubernetes configmaps feature: Auto-completion for kubernetes mid-string Oct 13, 2023
@Delawen Delawen force-pushed the configmap-autocomplete branch 2 times, most recently from ca61a45 to f25a299 Compare October 13, 2023 12:46
@apupier
Copy link
Member

apupier commented Oct 13, 2023

Not sure if this deserves a changelog or it can be included as part of the kubernetes context auto-completion lines in the changelog.

given that there was no release with it, i think we cna consider it as included in the other parts

Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • indentation: spaces are used in several places
  • I think it is worthy to add test cases for:
    ** several placeholders
    ** }} being before a {{, so for the value, something like pgevent:host:999/database/channel?user=}}something{{a

@apupier
Copy link
Member

apupier commented Oct 17, 2023

Please rebase so that the PR is launched on Java 21.

(and it is a good habit to always rebase when providing new changes to ensure it is not diverging too much from main branch)

@Delawen Delawen merged commit dfb7866 into camel-tooling:main Oct 18, 2023
4 checks passed
@Delawen Delawen deleted the configmap-autocomplete branch October 18, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants