Making the inital commit #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muskansethi1
reviewed
Oct 8, 2024
lib/plugin.js
Outdated
| @@ -56,8 +57,36 @@ cds.once("served", async function registerPluginHandlers() { | |||
| } | |||
| } | |||
|
|
|||
| function computeAttachment(req) { | |||
There was a problem hiding this comment.
rename the function, something like checkAttachmentLength?
lib/plugin.js
Outdated
| @@ -41,6 +41,7 @@ cds.once("served", async function registerPluginHandlers() { | |||
| srv.before("READ", [target, target.drafts], validateAttachment); | |||
|
|
|||
| srv.after("READ", [target, target.drafts], readAttachment); | |||
| srv.before("PUT", [target, target.drafts], computeAttachment); | |||
There was a problem hiding this comment.
do we need to do this in target too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the upload size of an attachment in the attachment plugin. Currently the maximum size size of data that can be scanned by the Malware Scanning Service on BTP is 400MB. So we would limit the file upload size to 400 MB.
Handling PUT request with 'before' handler to fetch the content length of the uploaded attachment in plugin.js.
Impose validation checks for size limit and rejecting the request which are above size limit.
Currently cannot access the UI part but validation checks are both imposed for hybrid and local mode.