-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore test.ts usages #8
Conversation
@danjoa I have fixed the import error that caused the test to fail before. We now have a new problem during runtime where |
I see you added these lines 2 weeks ago. → these likely never worked, did they? |
Sorry, I am not entirely clear on that. As I have copied the contents of this repo over from our internal one I am showing up as author on most files right now. But the lines in question have been present in the internal repository since September, not authored by me. So I can not speak for whether they ever worked. But it sounds like we can just remove those, as they are not supposed to work? |
ab1ac36
to
ba14c97
Compare
ba14c97
to
84b1bd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Use declaration merging on base classes * Remove tests
@daogrady can you check again, so that we can merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing that all tests pass, I think we are good to go. Thank you for your contributions!
No description provided.