fix(odata): Fix <Record> example for null value
#1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to annotation flattening, the value `null` would _not_ be rendered as `<Null/>` in OData EDMX. Instead, as the section before that mentions, we need to use special `$edmJson` syntax.
bugwelle
commented
Oct 17, 2024
advanced/odata.md
Outdated
| @@ -360,7 +360,7 @@ Record-like source structures are mapped to `<Record>` nodes in EDMX, with primi | |||
|
|
|||
| ```cds | |||
| @Some.Record: { | |||
| Null: null, | |||
| Null: { $edmJson: { $Null } }, | |||
There was a problem hiding this comment.
If there is special handling of record-annotation-types, I stand corrected. However, due to annotation flattening, such entries wouldn't be propagated properly anyway.
There was a problem hiding this comment.
yes that's wrong especially as a couple of lines @Some.Null explains how it should be. However, all this was written before we had this:
@UI.rec: { Null: (null) }renders into:
<Annotation Term="UI.rec">
<Record>
<PropertyValue Property="Null">
<Null/>
</PropertyValue>
</Record>
</Annotation>
There was a problem hiding this comment.
Indeed, thanks for reminding me! 😄
I've updated the sections.
hjboth
approved these changes
Oct 17, 2024
renejeglinsky
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to annotation flattening, the value
nullwould not be rendered as<Null/>in OData EDMX. Instead, as the section before that mentions, we need to use special$edmJsonsyntax or the new expression syntax(null).Tested with cds-compiler v5.3.2