Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Change the structure of the log to make the log sdk more light… #83

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

dgzpg
Copy link
Contributor

@dgzpg dgzpg commented Dec 9, 2021

Description

Change the structure of the log to make the log sdk more lightweight.

Lower the log adjustment level to the specific implementation part.

Issue reference

#82

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…weight.

Change the structure of the log to make the log sdk more lightweight.

Lower the log adjustment level to the specific implementation part.

#82
@dgzpg
Copy link
Contributor Author

dgzpg commented Dec 9, 2021

@kevinten10
Please help under the codeview, thank you

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #83 (b2e5bdc) into master (e873b73) will increase coverage by 2.83%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage     59.93%   62.76%   +2.83%     
  Complexity      453      453              
============================================
  Files           106      103       -3     
  Lines          1772     1692      -80     
  Branches        142      130      -12     
============================================
  Hits           1062     1062              
+ Misses          615      535      -80     
  Partials         95       95              
Impacted Files Coverage Δ
...oup/rxcloud/capa/spi/log/CapaLog4jAppenderSpi.java 0.00% <0.00%> (ø)
...p/rxcloud/capa/spi/log/CapaLogbackAppenderSpi.java 0.00% <0.00%> (ø)
...group/rxcloud/capa/spi/log/manager/LogManager.java
...group/rxcloud/capa/spi/log/enums/CapaLogLevel.java
...d/capa/spi/log/configuration/LogConfiguration.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e873b73...b2e5bdc. Read the comment docs.

Copy link
Member

@kevinten10 kevinten10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgzpg dgzpg merged commit 3223d4c into master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants