Test with and without spark #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdawang
requested review from
fdosani,
ak-gupta,
gladysteh99 and
NikhilJArora
as code owners
|
@jdawang you might need to rebase |
fdosani
approved these changes
Dec 8, 2023
Merged
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 12, 2024
* Test without spark * Bump setup python version * Separate tests out * Install datacompy step * Drop 3.0 and add 3.5 * Add fugue no spark * Add permissions * Format and docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #251, except shifting around the tests to be able to test under more installs and potentially more isolated builds in the future.
test_fugue.pyinto multiple files, one for each backend that allows for skips if the backend cannot be imported.datacompy[tests-spark]extras to allow to install[tests]extras without the spark test extras.