-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas on Spark refactor #275
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6c9f5f8
refactor SparkCompare
fdosani 1b57b61
tweaking SparkCompare and adding back Legacy
fdosani e080b25
conditional import
fdosani f0ddac6
cleaning up tests and using pytest-spark for legacy
fdosani 5017b28
adding docs
fdosani afd8945
caching and some typo fixes
fdosani 8d2906a
adding in doc and pandas 2 changes
fdosani 5d6661c
adding pandas to testing matrix
fdosani fadd3c1
drop 3.8
fdosani 7b2bc4e
drop 3.8
fdosani 0b990ca
refactoring ^
fdosani c81315d
rebase fix for #277
2381110
fixing legacy uncode column names
959b320
unicode fix for legacy
fdosani 456a8f1
unicode test for new spark logic
fdosani 069fc85
typo fix
fdosani 03e5659
changes from PR review
fdosani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
__version__ = "0.11.3" | ||
__version__ = "0.12.0" | ||
|
||
from datacompy.core import * | ||
from datacompy.fugue import ( | ||
|
@@ -25,4 +25,4 @@ | |
unq_columns, | ||
) | ||
from datacompy.polars import PolarsCompare | ||
from datacompy.spark import NUMERIC_SPARK_TYPES, SparkCompare | ||
from datacompy.spark import SparkCompare | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add newline There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're not testing on py38, I think this would warrant a formal declaration of dropping support + changing supported versions in the pyproject.toml. Learned this the hard way haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making changes in
pyproject.toml