Fix suffix on all mismatches reports #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdosani
requested review from
ak-gupta,
jdawang,
gladysteh99 and
NikhilJArora
as code owners
|
@enzorooo If you have a second to pull down this branch and test it out. Would greatly appreciate it. |
|
Amazing thanks @fdosani! |
|
Sure will take a look. I'll circle back when I am able! |
|
Looks good on my end! Thanks guys! |
Merged
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 11, 2024
* Fix all_mismatch report attribute to use defined df*_name by users * Add contributor credit * adding in additional changes for df names * adding in additional changes for df names --------- Co-authored-by: enzorooo <ph.enzomercado@gmail.com>
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 12, 2024
* Fix all_mismatch report attribute to use defined df*_name by users * Add contributor credit * adding in additional changes for df names * adding in additional changes for df names --------- Co-authored-by: enzorooo <ph.enzomercado@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #291
cc: @enzorooo
Pushing a new branch with some additional changes: