Update diff2html version which handles unknown filetypes gracefully #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caponetto
requested changes
Aug 28, 2023
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "vscode-diff-viewer", | |||
| "displayName": "Diff Viewer", | |||
| "description": "Visualize git diff files in VS Code", | |||
| "version": "1.4.2", | |||
| "version": "1.4.3", | |||
There was a problem hiding this comment.
Can you please revert this change?
There was a problem hiding this comment.
Done. My bad, I was trying to be helpful :)
caponetto
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #83 . Previously, diff2html would not gracefully fall back to plaintext for certain file types, which then would mess up vscode-diff-viewer (see this discussion thread and the subsequent PR). This PR is to pick up the new diff2html version, which I have tested locally and works.