IMP: transition to pyproject.toml #24
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1 (sans documentation, will link PR once that's been added)
Couple of thoughts/notes (cc @gregcaporaso):
One thing we don't have in here is a templated meta.yaml file - I'm not sure if it makes sense to add that for a starter plugin over having folks actually create that file on their own. they won't necessarily need it unless they'd like to build their package using conda (which isn't necessary for the ci template i created for weekly builds, that just utilizes a pip install).
Another thing with these changes is that since we're no longer vendoring versioneer (which is why the top level versioneer.py file is gone) the plugin developer will need to have versioneer installed in whatever environment they're developing in (otherwise their package won't build successfully). I need to confirm that this will work with the spec in pyproject.toml but as long as that works, they shouldn't have to do anything extra on their end.