update to reflect changes in metadata for manuscript preparation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if `export_legend` is enabled, present the legend in the resulting Visualization. Note that there was a minor bug in the original version of the Visualizer - since the conditional was being evaluated after `export_legend` was cast to a string, it always evaluated to `True`.
Co-authored-by: Liz Gehret <54517601+lizgehret@users.noreply.github.com>
Co-authored-by: Liz Gehret <54517601+lizgehret@users.noreply.github.com>
Co-authored-by: Liz Gehret <54517601+lizgehret@users.noreply.github.com>
Co-authored-by: Liz Gehret <54517601+lizgehret@users.noreply.github.com>
lizgehret
reviewed
Oct 17, 2024
| @@ -475,9 +484,16 @@ def plot_pcoa_2d(metadata_fp, ordination_fp, measure, | |||
| ax.plot([x0_bulk_mean, x1_mean], [y0_bulk_mean, y1_mean], | |||
| '--', color='#C5C9C7', linewidth=0.75, zorder=2) | |||
|
|
|||
| # handling title text for buckets depending on bucket highlighting | |||
There was a problem hiding this comment.
hey @gregcaporaso i added this segment below to improve the title text - i'll attach a few images to the main PR description so you can see what this looks like. other than this update, everything looks g2g!
|
hey @gregcaporaso here's what the updated title text looks like:
If you're okay with these changes, this should be ready to merge! |
|
Looks great, thanks @lizgehret! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.