Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds glossary entry and improves style consistency #238

Conversation

aturner-epcc
Copy link
Contributor

Closes #235

Copy link

github-actions bot commented Jul 31, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-238

The following changes were observed in the rendered markdown documents:

 fig/containers-cookie-cutter.png (new) | Bin 0 -> 412593 bytes
 introduction.md                        |  16 +++++++++-------
 md5sum.txt                             |   4 ++--
 reference.md                           |   2 ++
 4 files changed, 13 insertions(+), 9 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-31 17:27:37 +0000

github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
@aturner-epcc aturner-epcc merged commit d90daf4 into carpentries-incubator:main Aug 1, 2024
3 checks passed
@aturner-epcc aturner-epcc deleted the aturner-epcc/glossary-entries-235 branch August 1, 2024 08:03
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Auto-generated via {sandpaper}
Source  : d90daf4
Branch  : main
Author  : Andy Turner <a.turner@epcc.ed.ac.uk>
Time    : 2024-08-01 08:03:14 +0000
Message : Merge pull request #238 from aturner-epcc/aturner-epcc/glossary-entries-235

Adds glossary entry and improves style consistency
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Auto-generated via {sandpaper}
Source  : da86045
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-08-01 08:03:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d90daf4
Branch  : main
Author  : Andy Turner <a.turner@epcc.ed.ac.uk>
Time    : 2024-08-01 08:03:14 +0000
Message : Merge pull request #238 from aturner-epcc/aturner-epcc/glossary-entries-235

Adds glossary entry and improves style consistency
@jcohen02 jcohen02 added the peer review:editorial comment Editorial comments to be addressed from the peer review label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing glossary links
2 participants