Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add learner profiles content for workbench template #244

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

jcohen02
Copy link
Contributor

@jcohen02 jcohen02 commented Aug 5, 2024

This PR addresses issue #225 relating to the target audience for the lesson:

  • Adds a top-level "Target audience" box on the lesson intro page providing a brief note on the target audience.
  • Copies the learner profiles content from the instructor notes section to the new learner profiles page in the workbench template.
  • Adds some introductory text around the profiles content to ensure this is aimed at learners rather than instructors.

Closes #225

Copy link

github-actions bot commented Aug 5, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-244

The following changes were observed in the rendered markdown documents:

 index.md            | 18 ++++++++++
 learner-profiles.md | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++--
 md5sum.txt          |  4 +--
 3 files changed, 116 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-05 09:38:12 +0000

@jcohen02 jcohen02 added the peer review:editorial comment Editorial comments to be addressed from the peer review label Aug 5, 2024
github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
Copy link
Contributor

@aturner-epcc aturner-epcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @jcohen02 . I'll merge it now.

@aturner-epcc aturner-epcc merged commit b91e37c into carpentries-incubator:main Aug 16, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
Auto-generated via {sandpaper}
Source  : b91e37c
Branch  : main
Author  : Andy Turner <a.turner@epcc.ed.ac.uk>
Time    : 2024-08-16 08:18:34 +0000
Message : Merge pull request #244 from jcohen02/fix/issue225

Add learner profiles content for workbench template
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
Auto-generated via {sandpaper}
Source  : cfb75e0
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-08-16 08:19:23 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b91e37c
Branch  : main
Author  : Andy Turner <a.turner@epcc.ed.ac.uk>
Time    : 2024-08-16 08:18:34 +0000
Message : Merge pull request #244 from jcohen02/fix/issue225

Add learner profiles content for workbench template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add section on target audience
2 participants