Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build: Updated dependencies, Rust toolchain, and comments #30

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Fix build: Updated dependencies, Rust toolchain, and comments #30

merged 6 commits into from
Mar 11, 2024

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Mar 7, 2024

The example was not building due to outdated dependecies and rust toolchain.

Changes:

  • Updated dependencies
  • Updated Rust toolchain
  • Improved comments: Comments were converted from // to /// in applicable places.
  • The deprecated constant DEFAULT_RUN_GENESIS_REQUEST was removed and replaced with PRODUCTION_RUN_GENESIS_REQUEST.

@sczembor sczembor requested a review from ipopescu March 7, 2024 13:18
ipopescu
ipopescu approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sczembor sczembor merged commit 1f72b94 into master Mar 11, 2024
2 checks passed
@sczembor sczembor deleted the update_deps branch March 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipopescu ipopescu ipopescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sczembor @ipopescu