Skip to content

Commit

Permalink
tests: check if we return an error for unknown NodeAffinity operator
Browse files Browse the repository at this point in the history
  • Loading branch information
vladklokun committed Aug 20, 2024
1 parent fb17e56 commit 0e15fad
Showing 1 changed file with 42 additions and 9 deletions.
51 changes: 42 additions & 9 deletions castai/resource_node_template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -270,20 +270,53 @@ func Test_flattenNodeAffinity(t *testing.T) {
return wantNA
}

tt := []struct {
name string
inputNodeAffinity []sdk.NodetemplatesV1TemplateConstraintsDedicatedNodeAffinity
wantNodeAffinity []map[string]any
wantErr bool
}{
{
name: "should produce an error for an unknown operator",
inputNodeAffinity: makeSDKNodeAffinityWithOperator("UNKNOWN"),
wantNodeAffinity: makeMappedNodeAffinityWithOperator(""),
wantErr: true,
},
}

for _, canonical := range nodeSelectorOperators {
testedVariants := []string{canonical, strings.ToLower(canonical), strings.ToUpper(canonical)}
for _, variant := range testedVariants {
name := fmt.Sprintf("should map %q to %q", variant, canonical)
t.Run(name, func(t *testing.T) {
r := require.New(t)
input := makeSDKNodeAffinityWithOperator(variant)
want := makeMappedNodeAffinityWithOperator(canonical)

got, _ := flattenNodeAffinity(input)
r.Equal(want, got)
})
tcName := fmt.Sprintf("should map %q to %q", variant, canonical)
input := makeSDKNodeAffinityWithOperator(variant)
want := makeMappedNodeAffinityWithOperator(canonical)

tc := struct {
name string
inputNodeAffinity []sdk.NodetemplatesV1TemplateConstraintsDedicatedNodeAffinity
wantNodeAffinity []map[string]any
wantErr bool
}{
name: tcName,
inputNodeAffinity: input,
wantNodeAffinity: want,
wantErr: false,
}

tt = append(tt, tc)
}
}

for _, tc := range tt {
t.Run(tc.name, func(t *testing.T) {
r := require.New(t)
got, err := flattenNodeAffinity(tc.inputNodeAffinity)
r.Equal(tc.wantNodeAffinity, got)
if tc.wantErr {
r.Error(err)
}
})
}
}

func TestNodeTemplateResourceReadContextEmptyList(t *testing.T) {
Expand Down

0 comments on commit 0e15fad

Please sign in to comment.