Fix UT for eviciton config

castai · Jan 18, 2024 · 23e0b31 · 23e0b31
1 parent 99a4709
commit 23e0b31
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/castai/resource_eviction_config.go b/castai/resource_eviction_config.go
@@ -407,6 +407,10 @@ func toPodSelector(in interface{}) (*sdk.CastaiEvictorV1PodSelector, error) {
 				if len(me) < 1 {
 					continue
 				}
+
+				if out.LabelSelector == nil {
+					out.LabelSelector = &sdk.CastaiEvictorV1LabelSelector{}
+				}
 				out.LabelSelector.MatchExpressions = &me
 			} else {
 				return nil, fmt.Errorf("mapping match_expressions expecting map[string]interface, got %T, %+v", v, v)
@@ -417,6 +421,9 @@ func toPodSelector(in interface{}) (*sdk.CastaiEvictorV1PodSelector, error) {
 				return nil, err
 			}
 
+			if out.LabelSelector == nil {
+				out.LabelSelector = &sdk.CastaiEvictorV1LabelSelector{}
+			}
 			out.LabelSelector.MatchLabels = mls
 		}
 	}

diff --git a/castai/resource_eviction_config_test.go b/castai/resource_eviction_config_test.go
@@ -298,7 +298,7 @@ func TestEvictionConfig_UpdateContext(t *testing.T) {
 		Settings: sdk.CastaiEvictorV1EvictionSettings{Aggressive: &sdk.CastaiEvictorV1EvictionSettingsSettingEnabled{Enabled: true}},
 		PodSelector: &sdk.CastaiEvictorV1PodSelector{
 			Kind: lo.ToPtr("Job"),
-			LabelSelector: sdk.CastaiEvictorV1LabelSelector{
+			LabelSelector: &sdk.CastaiEvictorV1LabelSelector{
 				MatchLabels: &sdk.CastaiEvictorV1LabelSelector_MatchLabels{AdditionalProperties: map[string]string{
 					"key1": "value1",
 				}}}}}