fix: remove unsupported PreferNoSchedule taint effect option

castai · Sep 18, 2023 · 44816cf · 44816cf
1 parent c390f18
commit 44816cf
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 13 deletions.
diff --git a/castai/resource_node_template.go b/castai/resource_node_template.go
@@ -55,9 +55,8 @@ const (
 )
 
 const (
-	TaintEffectNoSchedule       = "NoSchedule"
-	TaintEffectNoExecute        = "NoExecute"
-	TaintEffectPreferNoSchedule = "PreferNoSchedule"
+	TaintEffectNoSchedule = "NoSchedule"
+	TaintEffectNoExecute  = "NoExecute"
 )
 
 const (
@@ -353,9 +352,9 @@ func resourceNodeTemplate() *schema.Resource {
 							Type:     schema.TypeString,
 							Default:  TaintEffectNoSchedule,
 							ValidateDiagFunc: validation.ToDiagFunc(
-								validation.StringInSlice([]string{TaintEffectNoSchedule, TaintEffectNoExecute, TaintEffectPreferNoSchedule}, false),
+								validation.StringInSlice([]string{TaintEffectNoSchedule, TaintEffectNoExecute}, false),
 							),
-							Description: "Effect of a taint to be added to nodes created from this template.",
+							Description: fmt.Sprintf("Effect of a taint to be added to nodes created from this template, the default is %s. Allowed values: %s.", TaintEffectNoSchedule, strings.Join([]string{TaintEffectNoSchedule, TaintEffectNoExecute}, ", ")),
 						},
 					},
 				},
@@ -909,7 +908,7 @@ func flattenCustomTaints(taints *[]sdk.NodetemplatesV1Taint) []map[string]string
 			t[FieldValue] = toString(v)
 		}
 		if e := taint.Effect; e != nil {
-			t[FieldEffect] = toString(e)
+			t[FieldEffect] = string(*e)
 		}
 
 		ts = append(ts, t)

diff --git a/castai/sdk/api.gen.go b/castai/sdk/api.gen.go
diff --git a/docs/resources/node_template.md b/docs/resources/node_template.md