Fix rebalancing schedules and phase 1 clusters (#241)

castai/resource_rebalancing_job_test.go → castai/resource_rebalancing_job_eks_test.go

@@ -2,53 +2,55 @@ package castai
 
 import (
 	"fmt"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 	"testing"
 )
 
-func TestAccResourceRebalancingJob_basic(t *testing.T) {
+func TestAccResourceRebalancingJob_eks(t *testing.T) {
+	rName := fmt.Sprintf("%v-rebalancing-job-%v", ResourcePrefix, acctest.RandString(8))
+	clusterName := "core-tf-acc"
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck: func() { testAccPreCheck(t) },
 
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{
-				Config: makeInitialRebalancingJobConfig(),
+				Config: makeInitialRebalancingJobConfig(rName, clusterName),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("castai_rebalancing_job.test", "enabled", "true"),
 				),
 			},
 			{
 				ResourceName: "castai_rebalancing_job.test",
 				ImportStateIdFunc: func(s *terraform.State) (string, error) {
-					clusterID := s.RootModule().Resources["castai_eks_clusterid.test"].Primary.ID
-					rebalancingScheduleName := "test"
-					return fmt.Sprintf("%v/%v", clusterID, rebalancingScheduleName), nil
+					clusterID := s.RootModule().Resources["castai_eks_cluster.test"].Primary.ID
+					return fmt.Sprintf("%v/%v", clusterID, rName), nil
 				},
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
 			{
-				Config: makeUpdatedRebalancingJobConfig(),
+				Config: makeUpdatedRebalancingJobConfig(rName, clusterName),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("castai_rebalancing_job.test", "enabled", "false"),
 				),
 			},
 		},
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"aws": {
+				Source:            "hashicorp/aws",
+				VersionConstraint: "~> 4.0",
+			},
+		},
 	})
 }
 
-func makeRebalancingJobConfig(config string) string {
+func makeRebalancingJobConfig(rName, config string) string {
 	template := `
-resource "castai_eks_clusterid" "test" {
-  account_id   = "fake"
-  region       = "eu-central-1"
-  cluster_name = "fake"
-}
-
 resource "castai_rebalancing_schedule" "test" {
-	name = "test"
+	name = %[1]q
 	schedule {
 		cron = "5 4 * * *"
 	}
@@ -64,17 +66,18 @@ resource "castai_rebalancing_schedule" "test" {
 }
 
 resource "castai_rebalancing_job" "test" {
-	cluster_id = castai_eks_clusterid.test.id
+	cluster_id = castai_eks_cluster.test.id
 	rebalancing_schedule_id = castai_rebalancing_schedule.test.id
-	%s
+	%[2]s
 }
 `
-	return fmt.Sprintf(template, config)
+	return fmt.Sprintf(template, rName, config)
 }
 
-func makeInitialRebalancingJobConfig() string {
-	return makeRebalancingJobConfig("")
+func makeInitialRebalancingJobConfig(rName, clusterName string) string {
+	return ConfigCompose(testAccEKSClusterConfig(rName, clusterName), makeRebalancingJobConfig(rName, ""))
 }
-func makeUpdatedRebalancingJobConfig() string {
-	return makeRebalancingJobConfig("enabled=false")
+
+func makeUpdatedRebalancingJobConfig(rName, clusterName string) string {
+	return ConfigCompose(testAccEKSClusterConfig(rName, clusterName), makeRebalancingJobConfig(rName, "enabled=false"))
 }