Handle tri-state values in node templates

castai/resource_node_template.go

@@ -221,7 +221,6 @@
 						FieldNodeTemplateStorageOptimized: {
 							Type:        schema.TypeBool,
 							Optional:    true,
-							Default:     false,
 							Description: "Storage optimized instance constraint - will only pick storage optimized nodes if true",
 						},
 						FieldNodeTemplateIsGpuOnly: {
@@ -233,7 +232,6 @@
 						FieldNodeTemplateComputeOptimized: {
 							Type:        schema.TypeBool,
 							Optional:    true,
-							Default:     false,
 							Description: "Compute optimized instance constraint - will only pick compute optimized nodes if true.",
 						},
 						FieldNodeTemplateInstanceFamilies: {
@@ -793,7 +791,7 @@
 	}
 
 	if v, ok := d.Get(FieldNodeTemplateConstraints).([]any); ok && len(v) > 0 {
-		req.Constraints = toTemplateConstraints(v[0].(map[string]any))
+		req.Constraints = toTemplateConstraints(d, v[0].(map[string]any))
 	}
 
 	if v, _ := d.GetOk(FieldNodeTemplateCustomInstancesEnabled); v != nil {
@@ -864,7 +862,7 @@
 	}
 
 	if v, ok := d.Get(FieldNodeTemplateConstraints).([]any); ok && len(v) > 0 {
-		req.Constraints = toTemplateConstraints(v[0].(map[string]any))
+		req.Constraints = toTemplateConstraints(d, v[0].(map[string]any))
 	}
 
 	if v, _ := d.GetOk(FieldNodeTemplateCustomInstancesEnabled); v != nil {
@@ -1029,14 +1027,15 @@
 	return ts
 }
 
-func toTemplateConstraints(obj map[string]any) *sdk.NodetemplatesV1TemplateConstraints {
+func toTemplateConstraints(d *schema.ResourceData, obj map[string]any) *sdk.NodetemplatesV1TemplateConstraints {
 	if obj == nil {
 		return nil
 	}
 
 	out := &sdk.NodetemplatesV1TemplateConstraints{}
-	if v, ok := obj[FieldNodeTemplateComputeOptimized].(bool); ok {
-		out.ComputeOptimized = toPtr(v)
+	// todo: this must be replaced with tri-state enum as GetOkExists is deprecated
+	if v, exists := d.GetOkExists(FieldNodeTemplateConstraints + "." + FieldNodeTemplateComputeOptimized); exists {
+		out.ComputeOptimized = toPtr(v.(bool))
 	}
 	if v, ok := obj[FieldNodeTemplateFallbackRestoreRateSeconds].(int); ok {
 		out.FallbackRestoreRateSeconds = toPtr(int32(v))
@@ -1075,8 +1074,9 @@
 			out.Spot = toPtr(!v)
 		}
 	}
-	if v, ok := obj[FieldNodeTemplateStorageOptimized].(bool); ok {
-		out.StorageOptimized = toPtr(v)
+	// todo: this must be replaced with tri-state enum as GetOkExists is deprecated
+	if v, exists := d.GetOkExists(FieldNodeTemplateConstraints + "." + FieldNodeTemplateStorageOptimized); exists {
+		out.StorageOptimized = toPtr(v.(bool))
 	}
 	if v, ok := obj[FieldNodeTemplateUseSpotFallbacks].(bool); ok {
 		out.UseSpotFallbacks = toPtr(v)

castai/resource_node_template_test.go

@@ -400,6 +400,60 @@ func TestNodeTemplateResourceDelete_defaultNodeTemplate(t *testing.T) {
 		" false).", result[0].Detail)
 }
 
+func TestToTemplateConstraints_HandleTriStateValues(t *testing.T) {
+	tests := map[string]struct {
+		val        cty.Value
+		assertions func(*require.Assertions, *sdk.NodetemplatesV1TemplateConstraints)
+	}{
+		"all values empty except one": {
+			val: cty.ObjectVal(map[string]cty.Value{
+				FieldNodeTemplateConstraints: cty.ListVal([]cty.Value{
+					cty.ObjectVal(map[string]cty.Value{
+						FieldNodeTemplateMaxCpu: cty.NumberIntVal(100),
+					}),
+				}),
+			}),
+			assertions: func(r *require.Assertions, constraints *sdk.NodetemplatesV1TemplateConstraints) {
+				r.NotNil(constraints)
+				r.Nil(constraints.ComputeOptimized)
+				r.Nil(constraints.StorageOptimized)
+				r.Nil(constraints.Gpu)
+				r.Nil(constraints.InstanceFamilies)
+				r.Nil(constraints.MaxMemory)
+				r.Nil(constraints.MinMemory)
+				r.Nil(constraints.MinCpu)
+				r.Nil(constraints.Spot)
+				r.Nil(constraints.OnDemand)
+				r.Nil(constraints.UseSpotFallbacks)
+				r.Nil(constraints.EnableSpotDiversity)
+				r.Nil(constraints.SpotDiversityPriceIncreaseLimitPercent)
+				r.Nil(constraints.SpotInterruptionPredictionsEnabled)
+				r.Nil(constraints.SpotInterruptionPredictionsType)
+				r.Nil(constraints.CustomPriority)
+				r.Nil(constraints.DedicatedNodeAffinity)
+				r.Nil(constraints.Architectures)
+				r.Nil(constraints.Os)
+				r.Nil(constraints.IsGpuOnly)
+			},
+		},
+	}
+
+	for name, td := range tests {
+		t.Run(name, func(t *testing.T) {
+			r := require.New(t)
+			resource := resourceNodeTemplate()
+			state := terraform.NewInstanceStateShimmedFromValue(td.val, 0)
+			state.ID = "testing-template"
+
+			data := resource.Data(state)
+			constraintsArray := data.Get(FieldNodeTemplateConstraints).([]any)
+			constraintsMap := constraintsArray[0].(map[string]any)
+			result := toTemplateConstraints(data, constraintsMap)
+			td.assertions(r, result)
+		})
+	}
+}
+
 func TestAccResourceNodeTemplate_basic(t *testing.T) {
 	rName := fmt.Sprintf("%v-node-template-%v", ResourcePrefix, acctest.RandString(8))
 	resourceName := "castai_node_template.test"

examples/gke/gke_cluster_autoscaler_policies/castai.tf

@@ -105,12 +105,9 @@ module "castai-gke-cluster" {
         spot                          = true
         use_spot_fallbacks            = true
         min_cpu                       = 4
-        max_cpu                       = 100
         instance_families = {
           exclude = ["e2"]
         }
-        compute_optimized = false
-        storage_optimized = false
 
         # Optional: define custom priority for instances selection.
         #

examples/gke/gke_cluster_autoscaler_policies/version.tf

@@ -2,6 +2,7 @@ terraform {
   required_providers {
     castai = {
       source = "castai/castai"
+      version = "0.0.0-local"
     }
     kubernetes = {
       source = "hashicorp/kubernetes"