[DRAFT] Add description for resources & examples for resources/datasources

castai/resource_eks_cluster_id.go

@@ -16,6 +16,7 @@ func resourceEKSClusterID() *schema.Resource {
 		CreateContext: resourceEKSClusterIDCreate,
 		ReadContext:   resourceEKSClusterIDRead,
 		DeleteContext: resourceEKSClusterIDDelete,
+		Description:   "Retrieve CAST AI clusterid",
 		Schema: map[string]*schema.Schema{
 			"account_id": {
 				Type:             schema.TypeString,

castai/resource_eks_cluster_userarn.go

@@ -17,6 +17,7 @@ func resourceEKSClusterUserARN() *schema.Resource {
 		ReadContext:   resourceEKSUserARNRead,
 		CreateContext: resourceEKSUserARNCreate,
 		DeleteContext: resourceEKSUserARNDelete,
+		Description: "Retrieve EKS Cluster user arn",
 		Schema: map[string]*schema.Schema{
 			EKSClusterUserARNFieldClusterID: {
 				Type:             schema.TypeString,

castai/resource_eviction_config.go

@@ -126,14 +126,17 @@ func resourceEvictionConfig() *schema.Resource {
 						FieldEvictionOptionDisabled: {
 							Type:     schema.TypeBool,
 							Optional: true,
+							Description: "Marking pods as removalDisabled",
 						},
 						FieldEvictionOptionAggressive: {
 							Type:     schema.TypeBool,
+							Description: "Apply Aggressive mode to Evictor",
 							Optional: true,
 						},
 						FieldEvictionOptionDisposable: {
 							Type:     schema.TypeBool,
 							Optional: true,
+							Description: "Marking node as disposable",
 						},
 					},
 				},

castai/resource_node_configuration_gke_test.go

@@ -9,6 +9,12 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
+const (
+	// acceptanceTestClusterSubnetworkName points to the subnet that the acceptance test cluster uses.
+	// Actual value (should) be managed by our IaC repository and could be shared with other clusters as well.
+	acceptanceTestClusterSubnetworkName = "ext-prov-e2e-shared-ip-range-nodes"
+)
+
 func TestAccResourceNodeConfiguration_gke(t *testing.T) {
 	rName := fmt.Sprintf("%v-node-cfg-%v", ResourcePrefix, acctest.RandString(8))
 	resourceName := "castai_node_configuration.test"
@@ -127,14 +133,15 @@ resource "castai_gke_cluster" "test" {
 }
 
 func testAccGCPConfig(rName, clusterName, projectID string) string {
+
 	return fmt.Sprintf(`
 
 locals {
   service_account_id    = %[3]q
   cluster_name = %[1]q
   service_account_email = "${local.service_account_id}@$%[2]s.iam.gserviceaccount.com"
   custom_role_id        = "castai.tfAcc.${substr(sha1(local.service_account_id),0,8)}.tf"
-  subnet_id = "projects/%[2]s/regions/us-central1/subnetworks/%[1]s-ip-range-nodes"
+  subnet_id = "projects/%[2]s/regions/us-central1/subnetworks/%[4]s"
 }
 
 resource "google_service_account" "castai_service_account" {
@@ -177,5 +184,5 @@ resource "google_service_account_key" "castai_key" {
   public_key_type    = "TYPE_X509_PEM_FILE"
 }
 
-`, clusterName, projectID, rName)
+`, clusterName, projectID, rName, acceptanceTestClusterSubnetworkName)
 }

castai/resource_node_template.go

@@ -984,9 +984,9 @@ func updateDefaultNodeTemplate(ctx context.Context, d *schema.ResourceData, meta
 		for _, d := range diagnostics {
 			if d.Severity == diag.Error {
 				if strings.Contains(d.Summary, "node template not found") {
-					return retry.RetryableError(fmt.Errorf(d.Summary))
+					return retry.RetryableError(fmt.Errorf("%s", d.Summary))
 				}
-				return retry.NonRetryableError(fmt.Errorf(d.Summary))
+				return retry.NonRetryableError(fmt.Errorf("%s", d.Summary))
 			}
 		}
 		return nil