Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support CPU manufacturer node template constraint #367

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

mikenorgate
Copy link
Contributor

No description provided.

@mikenorgate mikenorgate requested a review from a team as a code owner August 21, 2024 09:50
@mikenorgate mikenorgate changed the title Support CPU manufacturer node template constraint feat: Support CPU manufacturer node template constraint Aug 22, 2024
Copy link
Contributor

@vladklokun vladklokun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -142,7 +143,7 @@ func resourceOrganizationMembersRead(ctx context.Context, data *schema.ResourceD
client := meta.(*ProviderConfig).api

organizationID := data.Id()
usersResp, err := client.UsersAPIListOrganizationUsersWithResponse(ctx, organizationID)
usersResp, err := client.UsersAPIListOrganizationUsersWithResponse(ctx, organizationID, &sdk.UsersAPIListOrganizationUsersParams{})
Copy link
Contributor

@vladklokun vladklokun Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question(non-blocking): just to confirm, these are changes required by the newly generated SDK, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@mikenorgate mikenorgate merged commit 62177d2 into master Aug 22, 2024
10 checks passed
@mikenorgate mikenorgate deleted the node-template-constraint-cpu branch August 22, 2024 13:32
eliAbdulrahman pushed a commit to eliAbdulrahman/terraform-provider-castai that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants