-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphql update #118
Graphql update #118
Conversation
evansiroky
commented
Oct 17, 2018
•
edited
Loading
edited
- update to latest gtfs-lib with graphQL update
- make the GraphQLController similar to other controllers
- add more jmeter tests for common graphQL queries
- Fix an error in FetchSingleFeedJob.java
- Make response logging faster by not fully parsing large responses
|
Codecov Report
@@ Coverage Diff @@
## dev #118 +/- ##
==========================================
- Coverage 5.15% 5.15% -0.01%
Complexity 93 93
==========================================
Files 133 133
Lines 6865 6872 +7
Branches 900 903 +3
==========================================
Hits 354 354
- Misses 6485 6490 +5
- Partials 26 28 +2
Continue to review full report at Codecov.
|
This PR is now ready for review as it no longer depends on conveyal/gtfs-lib#144. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @evansiroky. I have become increasingly skeptical of the wisdom of logging requests/responses within the application, but I think we should address that outside of this PR.