Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql update #118

Merged
merged 12 commits into from
Dec 11, 2018
Merged

Graphql update #118

merged 12 commits into from
Dec 11, 2018

Conversation

evansiroky
Copy link

@evansiroky evansiroky commented Oct 17, 2018

  • update to latest gtfs-lib with graphQL update
  • make the GraphQLController similar to other controllers
  • add more jmeter tests for common graphQL queries
  • Fix an error in FetchSingleFeedJob.java
  • Make response logging faster by not fully parsing large responses

@evansiroky evansiroky added the WIP Work in progress label Oct 17, 2018
@evansiroky evansiroky self-assigned this Oct 17, 2018
@evansiroky
Copy link
Author

evansiroky commented Oct 19, 2018

This PR depends on the changes in conveyal/gtfs-lib#144. A new release of gtfs-lib will need to be created in order for this PR to work out-of-the-box.

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #118 into dev will decrease coverage by <.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##               dev    #118      +/-   ##
==========================================
- Coverage     5.15%   5.15%   -0.01%     
  Complexity      93      93              
==========================================
  Files          133     133              
  Lines         6865    6872       +7     
  Branches       900     903       +3     
==========================================
  Hits           354     354              
- Misses        6485    6490       +5     
- Partials        26      28       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/conveyal/gtfs/GraphQLMain.java 0% <0%> (-47.37%) 0 <0> (-2)
...om/conveyal/datatools/common/utils/SparkUtils.java 29.67% <0%> (-2.1%) 9 <0> (ø)
...va/com/conveyal/datatools/manager/DataManager.java 59.34% <100%> (ø) 30 <0> (ø) ⬇️
...main/java/com/conveyal/gtfs/GraphQLController.java 20.93% <57.14%> (+20.93%) 2 <1> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d70c92...aecf1d1. Read the comment docs.

@evansiroky
Copy link
Author

This PR is now ready for review as it no longer depends on conveyal/gtfs-lib#144.

@evansiroky evansiroky removed the WIP Work in progress label Nov 20, 2018
@evansiroky evansiroky assigned landonreed and unassigned evansiroky Nov 20, 2018
Copy link
Member

@landonreed landonreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @evansiroky. I have become increasingly skeptical of the wisdom of logging requests/responses within the application, but I think we should address that outside of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants