Fail string errors silently #156
Conversation
| @@ -199,7 +198,7 @@ define( | |||
|
|
|||
| }); | |||
| }).catch(() => { | |||
| Notification.exception(new Error('Failed to load string: loading')); | |||
There was a problem hiding this comment.
Is there any info on the root cause in general? I'm guessing this leads to a bit of broken UI as well, that might be worth considering if its a somewhat frequent issue. If this is just network failures that are random, this is likely fine.
Also, if we are removing the notifications, I dont think we need the catchs at all, and they can just be removed?
There was a problem hiding this comment.
I haven't been able to identify the cause but I have seen it occur pretty frequently. That said, the way the missing string is handled seemed to cause more of a problem than the missing string and I don't rememeber observing any issues beyond the error keep popping up.
You're probably right about removing the catches so I'll take another look. It's a been a while so fresh eyes might see something different
Thanks for looking.
There was a problem hiding this comment.
Hi Peter, the catches are removed, can it be re-reviewed, please?
Fix for issue #155