Skip to content

Commit

Permalink
feat: add loghandlers as an exportable/importable field
Browse files Browse the repository at this point in the history
Note: it will export the value as-is, which will be a CSV value instead of an array of enabled options.

This format might be safer and easier to add new settings for, instead of implementing and mapping structured data back and forth.
  • Loading branch information
keevan committed Jul 24, 2023
1 parent daa92cd commit 4e9842a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion classes/dataflow.php
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ public function get_export_data() {
}

// Add settings (except name) under 'config'.
$configfields = ['enabled', 'concurrencyenabled'];
$configfields = ['enabled', 'concurrencyenabled', 'loghandlers'];
$yaml['config'] = new \stdClass();
foreach ($configfields as $field) {
$yaml['config']->$field = $this->raw_get($field);
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/sample-export.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: 'Example Dataflow'
config:
enabled: '0'
concurrencyenabled: '0'
loghandlers: ''
steps:
read:
name: read
Expand Down

0 comments on commit 4e9842a

Please sign in to comment.