fix: directory file list step to properly handle glob returns

catalyst · Jul 25, 2023 · d3d01e1 · d3d01e1
1 parent ebf33da
commit d3d01e1
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/classes/local/step/directory_file_list_trait.php b/classes/local/step/directory_file_list_trait.php
@@ -141,11 +141,13 @@ public function run() {
         }
 
         $pathpattern = $path . DIRECTORY_SEPARATOR . $pattern;
-        $filelist = glob($pathpattern, GLOB_BRACE) || [];
-        if ($filelist !== false) {
-            $this->apply_list_constraints($filelist, $returnvalue, $config->sort, $offset, $limit, $includedir, $path);
+        $filelist = glob($pathpattern, GLOB_BRACE);
+        if (empty($filelist)) {
+            $this->log->notice("No files returned", ['pattern' => $pathpattern]);
+            return [];
         }
 
+        $this->apply_list_constraints($filelist, $returnvalue, $config->sort, $offset, $limit, $includedir, $path);
         return $filelist;
     }