Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression for directory file list step - passing in boolean instead of array #814

Closed
keevan opened this issue Jul 25, 2023 · 1 comment · Fixed by #815
Closed

Regression for directory file list step - passing in boolean instead of array #814

keevan opened this issue Jul 25, 2023 · 1 comment · Fixed by #815

Comments

@keevan
Copy link
Contributor

keevan commented Jul 25, 2023

Directory file list: Argument 1 passed to tool_dataflows\local\step\connector_directory_file_list::apply_list_constraints() must be of the type array, bool given

@keevan
Copy link
Contributor Author

keevan commented Jul 25, 2023

Seems like the nature of glob is that it cannot distinguish between false / no results / error so it's probably safer to return an empty array if it fails, but still print the notice as the user is likely to expect one or more files returned (unless they are using the count)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant