Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directory file list step to properly handle glob returns #815

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

keevan
Copy link
Contributor

@keevan keevan commented Jul 25, 2023

No description provided.

@keevan keevan force-pushed the 814-fix-directory-file-list-step branch from d3d01e1 to 462a5e4 Compare July 25, 2023 02:37
@keevan
Copy link
Contributor Author

keevan commented Jul 25, 2023

Small update to PR, the filter were applied but the filtered list wasn't being returned 🤪 .. which is a bug

Also some surrounding doc updates.

Opted to go with $list = $this->somefunction(); return $list; as it makes more sense if reading step by step, instead of feeling like you need to function jump to understand what's going on.

@Peterburnett Peterburnett merged commit 4ea837d into MOODLE_35_STABLE Jul 25, 2023
25 checks passed
@Peterburnett Peterburnett deleted the 814-fix-directory-file-list-step branch July 25, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression for directory file list step - passing in boolean instead of array
2 participants