add abort step and refactored execute definition to be the same for all flow steps #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keevan
force-pushed
the
591-abort-flow-step
branch
from
b04564c
to
134578c
Compare
keevan
changed the title
jaypha
reviewed
Sep 13, 2022
keevan
force-pushed
the
591-abort-flow-step
branch
2 times, most recently
from
c92e8c3
to
26de907
Compare
- should trigger an abort on the whole dataflow if it was ever reached and processed. - add handling for abort, to finalise the run and persist the times - add abort step for "connectors", which triggers an abort if a condition is true Note that this might be redundant if an "if" condition was made availalble to most steps (connectors, non logic flows), but might be harder to follow visually and when there are skips.
keevan
force-pushed
the
591-abort-flow-step
branch
from
26de907
to
9d3d39a
Compare
jaypha
reviewed
Sep 14, 2022
jaypha
reviewed
Sep 14, 2022
- abort step, condition not required (defaults to true) - abort step, simplify conditions when to abort - add more logging to the abort step
Issues fixed:
1 - Comma required after last value in array declaration
3 - Expected 0 blank lines after function
1 - Multi-line array contains a single value
keevan
force-pushed
the
591-abort-flow-step
branch
from
9d3d39a
to
591c0de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #591
Should improve and help with the effort in #473