796 fix moodle 42 fatal with core external lib changes #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keevan
force-pushed
the
796-fix-moodle-42-fatal-with-core-external-lib-changes
branch
from
86759b7
to
2769e43
Compare
keevan
force-pushed
the
796-fix-moodle-42-fatal-with-core-external-lib-changes
branch
from
6860e59
to
dae3455
Compare
keevan
force-pushed
the
796-fix-moodle-42-fatal-with-core-external-lib-changes
branch
from
fb1165b
to
cd3f78f
Compare
keevan
force-pushed
the
796-fix-moodle-42-fatal-with-core-external-lib-changes
branch
from
3276585
to
2144d96
Compare
|
Just a small CI blocker then this should be good |
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some code on top of the changes on top of the one PR started here by @opitz, with changes suggested by @aspark21 . The approach is here is to prevent branching due to a core file move.. where the API of the functions themselves do not change, only their namespace.
Costs of this approach, + one level of abstraction, IDEs don't have great support for this and won't pick up class methods/defs as easily
Benefits: We don't have to branch yet, I suspect support for pre 4.2 to still be round for some time.