Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix totara unit tests #822

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix totara unit tests #822

merged 2 commits into from
Aug 2, 2023

Conversation

keevan
Copy link
Contributor

@keevan keevan commented Aug 2, 2023 •
edited
Loading

  • test: avoid using class variables in this test to avoid mem leaks
  • test: use https mock url by default

Totara test results:

...............................................................  63 / 324 ( 19%)
............................................................... 126 / 324 ( 38%)
............................................................... 189 / 324 ( 58%)
............................................................... 252 / 324 ( 77%)
.....................................S......................... 315 / 324 ( 97%)
.........                                                       324 / 324 (100%)

Resolves #823

@keevan
test: avoid using class variables in this test to avoid mem leaks
421b439 
Per Totara unit test feedback/failures.
@keevan
test: use https mock url by default
3b63c24 
Resolves 301 redirect handling issue in one of the test
@Peterburnett Peterburnett merged commit a553594 into MOODLE_35_STABLE Aug 2, 2023
25 checks passed
@Peterburnett Peterburnett deleted the fix-totara-unit-tests branch August 2, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peterburnett Peterburnett Peterburnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Totara unit tests
2 participants
@keevan @Peterburnett