Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#851] Update composer libs #852

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Nov 30, 2023

Closes #851

The issue seemed to be the old version of symfony was spamming a ton of debug output messages, and then eventually got stuck in what seemed an infinite loop.

Changes:

  • Updated symfony/yaml from 3.4 -> 4.0.
    • 3.4 is the last 3.* version according to https://packagist.org/packages/symfony/yaml#v4.0.0
    • So I had to go to the next version, with is 4.0
    • 4.0 requires php 7.1 or above, so we should be good to make this a dataflows-wide change assuming tests pass seeing as we target php 7.4 and above

@matthewhilton matthewhilton changed the title [#851] Update symfony to version 4 [#851] Update composer libs Dec 1, 2023
@matthewhilton matthewhilton marked this pull request as ready for review December 1, 2023 00:07
Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt, it looks mostly good. I'm concerned about all the extra base composer file changes, and would like to keep it somewhat consistent.

Could you please check the changes here 851-update-dependencies...851-update-dependencies-extra-changes and see if you can cherry pick them into this PR?

All I need was update composer (composer self-update) and run the full install command in readme_moodle.txt.

@matthewhilton matthewhilton force-pushed the 851-update-dependencies branch 2 times, most recently from 7552656 to 5a0d81f Compare January 3, 2024 22:03
@matthewhilton
Copy link
Contributor Author

matthewhilton commented Jan 3, 2024

Good point - looks like my composer is on an older version as well. I just updated my composer to 2.6.6 and ran the composer update command which updated a few packages. Will wait and see if the CI passes now or if it still gets stuck

Edit: Looks like that didn't work either - so reverted back to previous, + cherry picked your commit, Kevin. Also had to re-add 4.2 as supported version so the CI runs for it.

Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Matt

@keevan keevan merged commit 909d9b5 into MOODLE_401_STABLE Jan 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants