-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#851] Update composer libs #852
Conversation
3320ecf
to
00ede90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Matt, it looks mostly good. I'm concerned about all the extra base composer file changes, and would like to keep it somewhat consistent.
Could you please check the changes here 851-update-dependencies...851-update-dependencies-extra-changes and see if you can cherry pick them into this PR?
All I need was update composer (composer self-update) and run the full install command in readme_moodle.txt.
7552656
to
5a0d81f
Compare
Good point - looks like my composer is on an older version as well. I just updated my composer to Edit: Looks like that didn't work either - so reverted back to previous, + cherry picked your commit, Kevin. Also had to re-add 4.2 as supported version so the CI runs for it. |
780fb97
to
f9c6833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Matt
Closes #851
The issue seemed to be the old version of symfony was spamming a ton of debug output messages, and then eventually got stuck in what seemed an infinite loop.
Changes: